pygae / galgebra

Symbolic Geometric Algebra/Calculus package for SymPy :crystal_ball:
https://galgebra.rtfd.io/
BSD 3-Clause "New" or "Revised" License
234 stars 62 forks source link

Remove all dependencies on galgebra.printer #452

Closed eric-wieser closed 6 months ago

eric-wieser commented 4 years ago

This means that the print customizations are now completely optional, and only take effect if import galgebra.printer is used. This is a good idea because these customizations may be surprising, as they:

This type of surprise should be opted into (by choosing to import this module), not automatic.

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging abda1e6a43ae39ddca453ecdea4dca10f0705531 into eb8ccd22c8ce865b985925ff2c22fda3a766891a - view on LGTM.com

new alerts:

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 76.47059% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 78.07%. Comparing base (dbff1ff) to head (d6b886f). Report is 80 commits behind head on master.

Files Patch % Lines
galgebra/metric.py 0.00% 9 Missing :warning:
galgebra/dop.py 54.54% 5 Missing :warning:
galgebra/ga.py 0.00% 2 Missing :warning:
galgebra/lt.py 80.00% 2 Missing :warning:
galgebra/mv.py 90.47% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #452 +/- ## ========================================== - Coverage 78.87% 78.07% -0.80% ========================================== Files 17 18 +1 Lines 4189 4169 -20 ========================================== - Hits 3304 3255 -49 - Misses 885 914 +29 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

utensil commented 6 months ago

Thank you, @eric-wieser , this should be superseded by #510 which merged gprinter from upstream. Feel free to reopen if there are remaining issues.