search

pygae / galgebra

Symbolic Geometric Algebra/Calculus package for SymPy :crystal_ball:
https://galgebra.rtfd.io/
BSD 3-Clause "New" or "Revised" License
227 stars 62 forks source link

Change tests to directly test the printer, rather than `__str__`. #476

Closed eric-wieser closed 3 years ago

eric-wieser commented 3 years ago

A small refactor of a test, extracted from #452. This makes the test less fragile to changes in how the printer hacks are set up - which is good, because its not trying to test the printer, but the results.

codecov[bot] commented 3 years ago

Codecov Report

Merging #476 (a1e7842) into master (dbff1ff) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #476   +/-   ##
=======================================
  Coverage   78.87%   78.87%           
=======================================
  Files          17       17           
  Lines        4189     4189           
=======================================
  Hits         3304     3304           
  Misses        885      885

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dbff1ff...a1e7842. Read the comment docs.

eric-wieser commented 3 years ago

Gonna put this in without review, since it's just a test and easy to revert if for whatever reason we decide to