Closed moble closed 3 months ago
Okay, I believe I've addressed the comments above.
The tests passed here.
Why is the doc build failed?
Other than this and the need to resolve the conflict, all LGTM.
Why is the doc build failed?
Looks like we were one of the lucky few to hit a brownout requiring the new .readthedocs.yaml format. I'll try to update it.
As everything looks good to me, and I wish to polish CI and bump Python etc. Merging this as the foundation. Thanks!
This PR attempts to replicate the CircleCI workflow (which is not working as of this writing) in github actions. It also removes references to CircleCI.
It also fixes a few minor things I needed to do to get the tests to pass:
getargspec
withgetfullargspec
ingalgebra/lt.py
self.nargs = 0
in the branch following thegetargspec
usage, so that it's not referring to a non-existent variableif
statement ingalgebra/mv.py
so the linter doesn't chokepython_requires
syntax insetup.py
This is one half of the split version of #486. The other half is a branch on my fork https://github.com/moble/galgebra/tree/jupyterlite, which starts relative to this PR's first commit; I'll make it into a PR once this is merged.