pygae / galgebra

Symbolic Geometric Algebra/Calculus package for SymPy :crystal_ball:
https://galgebra.rtfd.io/
BSD 3-Clause "New" or "Revised" License
225 stars 62 forks source link

Run tests on latest sympy #489

Closed moble closed 3 months ago

moble commented 11 months ago

As mentioned here the tests currently run on sympy 1.7; as of this writing, the current sympy version is 1.12, and the tests fail on it. When I removed the restriction to 1.7, I got a lot of failures that I'm guessing are related to sympy just organizing negative signs differently than it used to. This means that explicit comparisons to old results (as are done with nbval and in test_test.py) can fail spuriously. I suppose the thing to do would be to

  1. check more carefully than I have that most of those errors are indeed just sign-organization errors,
  2. re-run the notebooks to update their outputs, and
  3. update test_test.py to update its expected output.
utensil commented 3 months ago

Addressed by #493 .