search

pygame-community / pygame-ce

🐍🎮 pygame - Community Edition is a FOSS Python library for multimedia applications (like games). Built on top of the excellent SDL library.
https://pyga.me
777 stars 123 forks source link

Restore pygame.draw.aaline ` blend` argument #2739

Closed Starbuck5 closed 4 months ago

Starbuck5 commented 4 months ago

I got a report from Irv Kalb on discord that the removal of the blend argument in aaline in https://github.com/pygame-community/pygame-ce/pull/2506 broke some of their code.

I'm following up with them on how they didn't see (or did they just ignore?) the years of deprecation warnings.

Regardless, they suggested rather than removing the parameter entirely (resulting in crashes), it could just be ignored. I think this is a good idea. It could be ignored and raise a deprecation warning complaining about its use. If we want to remove it entirely, why not do that in a potential future pygame-ce 3?

ALSO, Irv pointed that the draw example at the bottom of the draw docs page still uses the argument. So that needs to be fixed.

Starbuck5 commented 4 months ago

@IrvKalb just got the fix for this merged into the main branch.