search

pygame-community / pygame-ce

🐍🎮 pygame - Community Edition is a FOSS Python library for multimedia applications (like games). Built on top of the excellent SDL library.
https://pyga.me
862 stars 141 forks source link

Undeprecate draw aaline blend #2743

Closed oddbookworm closed 6 months ago

oddbookworm commented 7 months ago

fixes #2739 and properly deprecates the blend argument so that if it's used, a warning will always be emitted instead of just false

oddbookworm commented 7 months ago

Perhaps the formatting changes that are unrelated to this PR should be a separate PR? It's probably the new version of clang-format messing things up. It has been causing my PRs to fail too

I opened #2744 to apply the formatting changes. I can rebase this pull when that merges

Starbuck5 commented 6 months ago

I think it’s fine to leave the feature removed (commits don’t need to be reverted). It’s just that the parameter should be un-removed and should always raise a depreciation warning.