search

pygame-community / pygame-ce

🐍🎮 pygame - Community Edition is a FOSS Python library for multimedia applications (like games). Built on top of the excellent SDL library.
https://pyga.me
773 stars 120 forks source link

Surface properties #2813

Closed ScriptLineStudios closed 1 month ago

ScriptLineStudios commented 2 months ago

Closes #2758

ScriptLineStudios commented 2 months ago

Interesting idea!

This PR is adding both .w and .width and .h and .height. Is this actually required? Is it being done for consistency with rect? If we add this we will end up having like atleast 3 ways of doing the exact same thing, which isn't very ideal IMHO

Yeah I also felt it was a little redundant, but yes did it for consistency with Rect.

Starbuck5 commented 2 months ago

Let's just do width, height, and size for now. (Removing w and h).

I think w and h would be fine to have, but in the interest of making this PR easy to merge let's remove them for now.

They can always be added in the future, but once they're added it's quite hard to remove.

ScriptLineStudios commented 2 months ago

Let's just do width, height, and size for now. (Removing w and h).

I think w and h would be fine to have, but in the interest of making this PR easy to merge let's remove them for now.

They can always be added in the future, but once they're added it's quite hard to remove.

Sounds good!