search

pygame-community / pygame-ce

🐍🎮 pygame - Community Edition is a FOSS Python library for multimedia applications (like games). Built on top of the excellent SDL library.
https://pyga.me
939 stars 155 forks source link

Add basic pygame.typing unit test, remove problematic TypeAlias usage #3150

Closed ankith26 closed 1 month ago

ankith26 commented 1 month ago

To catch issues like #3149

ankith26 commented 1 month ago

I have implemented a commit fixing the issue in this PR.

For now, the best fix seems to be reverting the TypeAlias changes entirely. And when our minimum supported python version becomes 3.12 (which should about 3 years from now), we can consider using the new type keyword and the other fancy new typing stuff.