pygame-community / pygame-ce

🐍🎮 pygame - Community Edition is a FOSS Python library for multimedia applications (like games). Built on top of the excellent SDL library.
https://pyga.me
941 stars 156 forks source link

better rect tests using literal values #3190

Open AntoineMamou opened 1 month ago

AntoineMamou commented 1 month ago

Fix the following functions in rect_test to use literal values for attribute checks : test_inflate__larger, test_inflatesmaller, test_inflate_iplarger and test_inflate_ip__smaller.

bilhox commented 1 month ago

Hi antoine, since you're new to contributing, let me give you one little advice on how you can improve your PRs next time. You don't have to mention the link of the issue in the title, you can mention it in your message directly. With this, you can opt for a more descriptive title for your PR.

bilhox commented 3 weeks ago

I think there is a little quiproquo, when I talked about tests for literal values, I meant for rect attributes, not these ones.

AntoineMamou commented 2 weeks ago

Hello @bilhox, I think I don't really understand what should be done. Could you explain more specifically, maybe ?

bilhox commented 2 weeks ago

Hello @bilhox, I think I don't really understand what should be done. Could you explain more specifically, maybe ?

What I meant is we should have a test similar to testCalculatedAttributes that check attributes values based on literal values.