Open AntoineMamou opened 1 month ago
Hi antoine, since you're new to contributing, let me give you one little advice on how you can improve your PRs next time. You don't have to mention the link of the issue in the title, you can mention it in your message directly. With this, you can opt for a more descriptive title for your PR.
I think there is a little quiproquo, when I talked about tests for literal values, I meant for rect attributes, not these ones.
Hello @bilhox, I think I don't really understand what should be done. Could you explain more specifically, maybe ?
Hello @bilhox, I think I don't really understand what should be done. Could you explain more specifically, maybe ?
What I meant is we should have a test similar to testCalculatedAttributes
that check attributes values based on literal values.
Fix the following functions in rect_test to use literal values for attribute checks : test_inflate__larger, test_inflatesmaller, test_inflate_iplarger and test_inflate_ip__smaller.