search

pygame-guide-for-sneks / pygame-guide-for-sneks.github.io

https://pygame-guide-for-sneks.github.io
MIT License
12 stars 8 forks source link

Classes #46

Closed oddbookworm closed 1 year ago

oddbookworm commented 2 years ago

Draft pr for axis to review

blankRiot96 commented 2 years ago

Thanks! First off, amazing article, I like the casual vibe you maintain throughout it

There are some technical issues, this is how all the code snippets look like for me image

I would like it if all the code were to start from the left edge of the code block, and of course the indentation seems to be missing here, but that was probably unintentional

image

The ellipses here is a bit ambiguous, I think you should explicitly mention what types you are talking about

The replit integration is really sweet. I guess the rest of the article is in progress

Matiiss commented 1 year ago

More of a GH thing but would be great if you could squash those commits into like one... or at least less than currently. I suppose it could be done by creating a temp branch from this branch, then resetting this branch to the beginning and then merge the temp branch into this one but I ain't no git whizz and it'd be really bad to lose the progress so maybe extra backups would be the way to go if you decide to do it this way I guess.

oddbookworm commented 1 year ago

More of a GH thing but would be great if you could squash those commits into like one... or at least less than currently. I suppose it could be done by creating a temp branch from this branch, then resetting this branch to the beginning and then merge the temp branch into this one but I ain't no git whizz and it'd be really bad to lose the progress so maybe extra backups would be the way to go if you decide to do it this way I guess.

When it gets merged, we can squash and merge

Matiiss commented 1 year ago

More of a GH thing but would be great if you could squash those commits into like one... or at least less than currently. I suppose it could be done by creating a temp branch from this branch, then resetting this branch to the beginning and then merge the temp branch into this one but I ain't no git whizz and it'd be really bad to lose the progress so maybe extra backups would be the way to go if you decide to do it this way I guess.

When it gets merged, we can squash and merge

Can merge commits be squashed?

oddbookworm commented 1 year ago

Can merge commits be squashed?

I think it squashes every commit, whether it's merge or not. I can try to squash it myself, but I don't want to royally screw it up

oddbookworm commented 1 year ago

Commits squashed down to a single commit

SSS-Says-Snek commented 1 year ago

Great article, andrew! Here are some minor things I noticed