Fix Bug on iOS Devices: "Ready to Start!" Screen Unresponsive

pygame-web / pygbag

python and pygame wasm for everyone ( packager + test server + simulator )

https://github.com/pygame-web

MIT License

319 stars 36 forks source link

Fix Bug on iOS Devices: "Ready to Start!" Screen Unresponsive #170

Open Dor-sketch opened 3 months ago

Dor-sketch commented 3 months ago

Fixes Issue #138 where the "Ready to Start!" screen is unresponsive on iOS devices. Updated the waiting loop in custom_site() in the template HTML files.

Changes Made:

Modified the waiting loop in custom_site() to improve event handling on iOS devices.

Testing:

Tested on one iOS device; further testing needed on other devices.

pmp-p commented 2 months ago

Thanks, fix indeed works for iOS but it relies on pygame, so it is only valid for "default.tmpl". For the other templates pygame is either not loaded, or must not init canvas contexts. So a javascript solution would have to be used there because browser don't allow to change contexts at runtime.

Also in its present form i fear it would defeat the chrome media-user-engagement learning process which allow often played games to start music automatically without a click. I would prefer is a way with detection that device is iOS and apply the fix only in that case.