pygbag cli: `--directory` and `--cache` arguments are not respected - Githubissues

pygame-web / pygbag

python and pygame wasm for everyone ( packager + test server + simulator )

https://github.com/pygame-web

MIT License

319 stars 36 forks source link

pygbag cli: `--directory` and `--cache` arguments are not respected #68

Open gabriel-v opened 1 year ago

gabriel-v commented 1 year ago

Parser args are added here:

But then, they are not being used at all, here:

https://github.com/pygame-web/pygbag/blob/17ae938392f0517d3644b5e68046048fc01ca731/pygbag/app.py#L296 (should be args.directory)
https://github.com/pygame-web/pygbag/blob/17ae938392f0517d3644b5e68046048fc01ca731/pygbag/app.py#L337 (should be args.cache)
https://github.com/pygame-web/pygbag/blob/17ae938392f0517d3644b5e68046048fc01ca731/pygbag/app.py#L129-L131 (should read from args, not set as app.folder / build)

I think we need to either remove the arguments or respect them.

My current workaround for this issue is to cp -a the stuff into a temporary directory before building.

pmp-p commented 1 year ago

Thank for reporting. Indeed commenting them until implemented correctly as they are confusing, and "build" is totally fine for python ecosystem anyway.