search

pygfx / pyshader

Write modern GPU shaders in Python!
BSD 2-Clause "Simplified" License
72 stars 1 forks source link

Fix spirv block decoration for storage buffers #49

Closed almarklein closed 4 years ago

almarklein commented 4 years ago

~May fix~ Fixes #48

almarklein commented 4 years ago

@pbauda could you please try to install this branch via pip install https://github.com/pygfx/pyshader/archive/bock.zip and then try again (with the shader fixed for GlobalInvocationId)?

This produces SpirV that is more similar to the SpirV originating from glsl. I found along the way that one decoration was applied to the wrong variable, and we may have been missing another decoration.

(CI failing is because we need to update the test-hashes, because the SpirV for many test has changed).

almarklein commented 4 years ago

I just tried on Ubuntu 20.04 and ran into similar problems as #48. I can confirm that this change fixes it.