search

pygfx / shadertoy

Shadertoy implementation based on wgpu-py
BSD 2-Clause "Simplified" License
10 stars 0 forks source link

Add vflip for textures #26

Closed Vipitis closed 3 months ago

Vipitis commented 3 months ago

part of #4

This PR ads the vertical flip option for texture inputs. By default images aren't upside down anymore. Additionally this PR includes a minor refactor to leverage the numpy and PIL runtime dependencies added in #25. This makes it a step easier to use custom images as textures. Fixes greyscale textures now behaving like the website reference (they are red).

Korijn commented 3 months ago

I would suggest to just drop 3.8 :)

Vipitis commented 3 months ago

that is also an option. However 3.8 is end of life in a few months and the typing syntax does change with seemingly every single release since. Type hints in python are very superficial anyways and not really a requirement, just helps the language server.

Alternatively if we really want typing that works across versions using the typing library should do it.

I am okay with leaving it as is