pygments / pygments.rb

💎 Ruby wrapper for Pygments syntax highlighter
MIT License
572 stars 141 forks source link

Bump yajl-ruby dependency from 1.1.0 -> 1.2.0 #106

Closed lencioni closed 9 years ago

lencioni commented 10 years ago

yajl-ruby 1.2.0 was recently released and contains a number of changes:

https://github.com/brianmario/yajl-ruby/compare/eef5c48be81b6404af66da3f185ec9301e5214d8...fb61daad73340968badf6f84e41ec6931db2e87e

vitaliel commented 10 years ago

Hi, What do we need to merge this?

XhmikosR commented 9 years ago

Why stay with old versions if the new versions do not break anything?

jimpo commented 9 years ago

+1. Old version conflicts with other gems.

benbalter commented 9 years ago

@tmm1 if you're able to bump yajl-ruby to 1.2.0 without issue, I believe this will fix an issue whereby the default Jekyll configuration doesn't work on windows, uncovered while adding Windows testing over in https://github.com/github/pages-gem/pull/112. Monkey patching the Gemfile to require 1.2.0 seems to work, fine, at least in the context of Jekyll, but I didn't test beyond that.

CCing for context, as it took a bit of digging to land here:

benbalter commented 9 years ago

:sparkles: Thanks @tmm1!

@parkr Pygments master should now work on Windows out of the box.

parkr commented 9 years ago

@parkr Pygments master should now work on Windows out of the box.

Thanks, @benbalter! :tada: /cc @XhmikosR

XhmikosR commented 9 years ago

Awesome, thanks! Now, we only need a new gem published.

amacneil commented 9 years ago

Any chance you can publish a new gem?

parkr commented 9 years ago

Bringing in the gem owners: /cc @tmm1 @tnm @vmg Thanks guys!

XhmikosR commented 9 years ago

Bump

tmm1 commented 9 years ago

Published 0.6.1 to rubygems

parkr commented 9 years ago

Thank you! :tada: :confetti_ball: :pray: :heart:

XhmikosR commented 9 years ago

Thanks a million times! This indeed fixes the Windows issue with yajl-ruby and Ruby >= 2.x.

Now, we need a new pages-gem because it has 0.6.0 hardcoded...