Closed lencioni closed 9 years ago
Hi, What do we need to merge this?
Why stay with old versions if the new versions do not break anything?
+1. Old version conflicts with other gems.
@tmm1 if you're able to bump yajl-ruby to 1.2.0 without issue, I believe this will fix an issue whereby the default Jekyll configuration doesn't work on windows, uncovered while adding Windows testing over in https://github.com/github/pages-gem/pull/112. Monkey patching the Gemfile to require 1.2.0 seems to work, fine, at least in the context of Jekyll, but I didn't test beyond that.
CCing for context, as it took a bit of digging to land here:
:sparkles: Thanks @tmm1!
@parkr Pygments master
should now work on Windows out of the box.
@parkr Pygments master should now work on Windows out of the box.
Thanks, @benbalter! :tada: /cc @XhmikosR
Awesome, thanks! Now, we only need a new gem published.
Any chance you can publish a new gem?
Bringing in the gem owners: /cc @tmm1 @tnm @vmg Thanks guys!
Bump
Published 0.6.1 to rubygems
Thank you! :tada: :confetti_ball: :pray: :heart:
Thanks a million times! This indeed fixes the Windows issue with yajl-ruby and Ruby >= 2.x.
Now, we need a new pages-gem because it has 0.6.0 hardcoded...
yajl-ruby 1.2.0 was recently released and contains a number of changes:
https://github.com/brianmario/yajl-ruby/compare/eef5c48be81b6404af66da3f185ec9301e5214d8...fb61daad73340968badf6f84e41ec6931db2e87e