search

pygments / pygments.rb

💎 Ruby wrapper for Pygments syntax highlighter
MIT License
572 stars 141 forks source link

Remove warnings #161

Closed JuanitoFatas closed 8 years ago

JuanitoFatas commented 8 years ago

Spotted while running tests (with Rake version >= 11.2.2):

- pygments.rb-0.6.3/lib/pygments/lexer.rb:39: warning: shadowing outer local variable - extname
- pygments.rb-0.6.3/lib/pygments/popen.rb:100: warning: instance variable @pid not initialized
mojavelinux commented 8 years ago

I see additional warnings when running tests under 2.3.0.

pygments.rb/test/test_pygments.rb:233: warning: mismatched indentations at 'end' with 'def' at 229
pygments.rb/test/test_pygments.rb:241: warning: ambiguous first argument; put parentheses or a space even after `/' operator
pygments.rb/test/test_pygments.rb:245: warning: ambiguous first argument; put parentheses or a space even after `/' operator
pygments.rb/test/test_pygments.rb:249: warning: ambiguous first argument; put parentheses or a space even after `/' operator
pygments.rb/test/test_pygments.rb:253: warning: ambiguous first argument; put parentheses or a space even after `/' operator
JuanitoFatas commented 8 years ago

@mojavelinux Thanks Dan, fixed in bf35f68.