pygments / pygments.rb

💎 Ruby wrapper for Pygments syntax highlighter
MIT License
572 stars 141 forks source link

Add GitLab formatter #77

Closed riyad closed 10 years ago

riyad commented 11 years ago

Adds the HTML formatter used by GitLab. (also see gitlabhq/pygments.rb#1)

Razer6 commented 11 years ago

:+1:

dzaporozhets commented 11 years ago

:+1:

avtobiff commented 11 years ago

I suppose this should actually go to pygments bitbucket?

https://bitbucket.org/birkenfeld/pygments-main

dosire commented 11 years ago

@avtobiff If it is needed to submit this on bitbucket I'm willing to do so but pull requests here seem to be merged too: https://github.com/tmm1/pygments.rb/pull/92

Merging this pull request would allow GitLab to use the original and get rid of our fork. I think this would help pygments and people packaging GitLab for Fedora and Debian, see https://github.com/axilleas/gsoc/blob/master/packaging.md#gitlab-pygmentsrb

Let us know if there is anything we can do to get this resolved.

tmm1 commented 11 years ago

Please submit this upstream.

dosire commented 11 years ago

@tmm1 Thanks for commenting. I've had a look at https://bitbucket.org/birkenfeld/pygments-main but they do not seems to be accepting any customer lexers or formatters, so this does not look like a feasible option. If there is anything we can do to make this PR acceptable to you please let us know. If there is nothing we can do we respect that too.

avtobiff commented 10 years ago

@dosire Quoting http://pygments.org/docs/plugins/

Extending The Core

If you have written a Pygments plugin that is open source, please inform us about that. There is a high chance that we’ll add it to the Pygments distribution.

dosire commented 10 years ago

@riyad I think you can close this since GitLab switched to highlight.js

riyad commented 10 years ago

done :)

dosire commented 10 years ago

@riyad Thanks!