Fix ssh container output issues

pygmystack / pygmy

the pygmy stack is a container stack for local development

MIT License

25 stars 13 forks source link

Fix ssh container output issues #109

Closed fubarhouse closed 4 years ago

fubarhouse commented 4 years ago

Feel free to dump more in here as I know of a few, but the scope for now includes:

Fix the following code block:

for _, Container := range c.Services {
    purpose, _ := Container.GetFieldString("purpose")
    //output, _ := Container.GetFieldBool("output")
    if purpose == "showkeys" {
        // TODO re-fix
        //Container.Output = true
        Container.Start()
    }
}

source: https://github.com/fubarhouse/pygmy-go/blob/0ba7b349da4866842afc18daee65d442131ac665/service/library/status.go#L88-L95

fubarhouse commented 4 years ago

Not running

$ pygmy status
Error response from daemon: No such container: amazeeio-ssh-agent

When standing up

$ pygmy up

Up works great, but the first letter of output could be trimmed,

When running

$ pygmy status
Failed to run amazeeio-ssh-agent-show-keys.

Multiple keys should already be supported, but I find a lack of evidence - we can clear this up here too.