[feature] implement `stop` command

pygmystack / pygmy

the pygmy stack is a container stack for local development

MIT License

25 stars 13 forks source link

[feature] implement `stop` command #288

Closed twardnw closed 3 years ago

twardnw commented 3 years ago

Currently the only option to stop the containers is with the down command, which removes _everything_related to Pygmy. While this is nice for cleanup, it is excessive. The Pygmy gem utilizes a stop command, which simply stops the containers. This command should be added to retain parity with the gem.

fubarhouse commented 3 years ago

Prioritizing this one - but similar was noted in #271

fubarhouse commented 3 years ago

Some questions about expected behavior:

should the networks attempt to be removed when running this command?
should the resolv configuration be removed when running this command?

twardnw commented 3 years ago

The current behavior in the gem version is to stop the containers (but not remove) and clean up the resolver. The network stays in place for stop

fubarhouse commented 3 years ago

There's now a test case which replicates the behavior in #271. Once the issue is fixed and the test case passes this will be good for merging.