Closed tobybellwood closed 10 months ago
Additionally, it doesn't appear that pygmy can easily handle pulling images that aren't present locally (same result without ghcr.io prefix)?
Additionally, it doesn't appear that pygmy can easily handle pulling images that aren't present locally (same result without ghcr.io prefix)?
Turns out this was an issue with some greedy regex in the DockerPull routine - i've fixed it in a test branch, but will PR.
I've now got a working version of this, though I'm not completely happy with the implementation.
I'll clean it up soon and open a PR. :+1:
Ooh nice! I'll take a look when you're done and we can get test suites into the images too!
Looks good, but haven't tested myself - only comment is that I'd use the :main images instead of the pr- ones
Happy to merge #469?
Still interested in this one @tobybellwood? I'm good to merge on your approval.
To allow local customisation, and facilitate easier testing, you should be able to define the image for a built-in service in the .pygmy.yml file (as you can for external services).
This would allow easier testing in the image repos etc
e.g.