pygobject / pycairo

Python bindings for cairo
https://pycairo.readthedocs.io
Other
613 stars 83 forks source link

Phantom method: stroke_to_path? #275

Closed nedbat closed 1 year ago

nedbat commented 1 year ago

The Context docs mention a method called Context.stroke_to_path in a few places, but it doesn't seem to exist?

nedbat commented 1 year ago

Hmm, from src/cairo.h:

/* XXX: NYI
cairo_public void
cairo_stroke_to_path (cairo_t *cr);
*/
stuaxo commented 1 year ago

NYI == not yet implemented ?

I wonder if it is still not yet implemented, and if so what needs doing ?

nedbat commented 1 year ago

Right, NYI is not yet implemented. I have no idea what's required. I think the best thing would be remove mention of it from PyCairo until cairo implements it.

stuaxo commented 1 year ago

Are we sure it's not implented in Cairo itself ?

nedbat commented 1 year ago

The cairo.h fragment is from Cairo: https://github.com/freedesktop/cairo/blob/master/src/cairo.h#L915-L918

I've made https://github.com/pygobject/pycairo/pull/276 to remove the mentions.

stuaxo commented 1 year ago

Yep. just saw how it's in the cairo possible "student projects" part of their website.

Maybe upstream cairo would have have better luck trying to use a crowdfunding model for some of the unimplemented bits.

stuaxo commented 1 year ago

Change looks good to me.

stuaxo commented 1 year ago

Thanks @nedbat I spent the time to go through and read your changes properly, so felt happy to use my rarely-used merging ability on this one :)