pygod-team / pygod

A Python Library for Graph Outlier Detection (Anomaly Detection)
https://pygod.org
BSD 2-Clause "Simplified" License
1.31k stars 127 forks source link

Hard to run benchmark scripts directly #81

Closed OldPanda closed 1 year ago

OldPanda commented 1 year ago

Is your feature request related to a problem? Please describe. I tried to run benchmark scripts on my local after installing the repo but failed.

Here's how I setup the environment.

First, I ran

  1. pip install -r requirements.txt
  2. python setup.py install

to install the repo and the dependencies. However, the following errors were complained when I tried to run python main.py under pygod/benchmark/

where the last one can be fixed by https://github.com/pygod-team/pygod/pull/80, but I still have to install the missing modules with commands

pip install tqdm
pip install torch
pip install torch-geometric
pip install pyod
pip install torch-sparse
pip install torch-scatter -f https://data.pyg.org/whl/torch-2.0.0+cpu.html

then I can run the benchmark script.

Describe the solution you'd like It would be better to have a dedicated requirements.txt file inside folder pygod/benchmark/ containing all the required dependencies.

Describe alternatives you've considered N/A

Additional context N/A

kayzliu commented 1 year ago

Thanks for pointing this out! It's a really good suggestion. For torch, torch-geometric, torch-sparse, etc., because of the diversity of environments (OS and CUDA), we would not be able to find the best version for you. Users are required to install by themselves, referring to the install guide. But I will add a requirements.txt file for the rest of the dependencies.

kayzliu commented 1 year ago

fixed in 7783b31a69c0f276b5c6f26a7d46763e7e42c03b.

OldPanda commented 1 year ago

Thanks for addressing it!