search

pyhf / pyhf-tutorial

Updating tutorial on pyhf
https://pyhf.github.io/pyhf-tutorial/
Apache License 2.0
9 stars 5 forks source link

fix: Update all APIs to pyhf v0.7.0 #34

Closed matthewfeickert closed 1 year ago

matthewfeickert commented 1 year ago

Resolves #33

Amends PR #29 

* Update all APIs to be consistent with v0.7.0.
   - Remove comment about making measurement on the fly with
     `workspace.get_measurement` as no longer relevant.
   - Remove all use of `workspace.parameters`, now
     `workspace.model().config.parameters`, as the notebooks
      are focusing on workspace attributes, not model config
      attributes.
* Amends PR #29
kratsg commented 1 year ago

I'd just drop the ws.parameters calls -- since the relevant portion of the tutorial is only talking about workspaces, not models.

matthewfeickert commented 1 year ago

I'd just drop the ws.parameters calls -- since the relevant portion of the tutorial is only talking about workspaces, not models.

@kratsg done.

matthewfeickert commented 1 year ago

Merging as have approval from Giordon over Skype.