pyhoneybot / honeybot

🛩 A python IRC bot with simple plugins dev. Ignited in mauritius, first-timers friendly!
https://pyhoneybot.github.io/honeybot-store/
MIT License
78 stars 88 forks source link

Adding the new plugin: basketball #187

Closed kefthymic closed 1 year ago

kefthymic commented 1 year ago

Description

I finished the basketball plugin. I tested my code using the test_plugin_script.

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: kefthymic
:x: pre-commit-ci-lite[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

Abdur-rahmaanJ commented 1 year ago

Great PR else!

Abdur-rahmaanJ commented 1 year ago

@MrTanoshii Please review

Abdur-rahmaanJ commented 1 year ago

hey @kefthymic Can you add it on the README? Thanks!

kefthymic commented 1 year ago

Hello @Abdur-rahmaanJ . I added the plugin on the README. Is it ok?

kefthymic commented 1 year ago

@MrTanoshii I formatted the README using the https://codebeautify.org/markdown-formatter as you told me and also ran the command for the main.py. Is there anything I need to do?

MrTanoshii commented 1 year ago

Thank you once again!

There's nothing else to do, your plugin is now merged 🥳