search

pyimreg / python-register

Linear and non-linear image registration methods, using scipy and numpy.
Other
62 stars 34 forks source link

Known issues document needed. #20

Closed riaanvddool closed 12 years ago

riaanvddool commented 13 years ago

We need a file that lists 'known issues'.

First candidate: Image data should be double, otherwise strange things might happen.

stefanv commented 13 years ago

Maybe just create issues and label them appropriately?

On Fri, Sep 9, 2011 at 1:39 AM, Riaan van den Dool reply@reply.github.com wrote:

We need a file that lists 'known issues'.

First candidate: Image data should be double, otherwise strange things might happen.

Reply to this email directly or view it on GitHub: https://github.com/nfaggian/python-register/issues/20

nfaggian commented 13 years ago

Agree - all fixes need a ticket and associated pull requests On Sep 13, 2011 7:57 AM, "Stefan van der Walt" < reply@reply.github.com> wrote:

Maybe just create issues and label them appropriately?

On Fri, Sep 9, 2011 at 1:39 AM, Riaan van den Dool reply@reply.github.com wrote:

We need a file that lists 'known issues'.

First candidate: Image data should be double, otherwise strange things might happen.

Reply to this email directly or view it on GitHub: https://github.com/nfaggian/python-register/issues/20

Reply to this email directly or view it on GitHub: https://github.com/nfaggian/python-register/issues/20#issuecomment-2075883

riaanvddool commented 13 years ago

I am confused. :( Does this mean we all have to fork the project?

Riaan

On Tue, Sep 13, 2011 at 12:51 AM, Nathan Faggian reply@reply.github.com wrote:

Agree - all fixes need a ticket and associated pull requests On Sep 13, 2011 7:57 AM, "Stefan van der Walt" < reply@reply.github.com> wrote:

Maybe just create issues and label them appropriately?

On Fri, Sep 9, 2011 at 1:39 AM, Riaan van den Dool reply@reply.github.com wrote:

We need a file that lists 'known issues'.

First candidate: Image data should be double, otherwise strange things might happen.

Reply to this email directly or view it on GitHub: https://github.com/nfaggian/python-register/issues/20

Reply to this email directly or view it on GitHub: https://github.com/nfaggian/python-register/issues/20#issuecomment-2075883

Reply to this email directly or view it on GitHub: https://github.com/nfaggian/python-register/issues/20#issuecomment-2076379

nfaggian commented 13 years ago

Hi,

I think when I started using github I went about it the wrong way.

Basically I think we should adopt the push/pull model, so each of us clone and submit a pull-request for changes.

I don't expect anything to really change - instead of making a branch on the shared repo we would just clone and issue pull requests. Ideally not pulling our own changes in, which forces us to review each others code and discuss the best approach for things.

Hope this isn't too much of a nuisance.

-N

On 13 September 2011 16:53, Riaan van den Dool reply@reply.github.com wrote:

I am confused. :( Does this mean we all have to fork the project?

Riaan

On Tue, Sep 13, 2011 at 12:51 AM, Nathan Faggian reply@reply.github.com wrote:

Agree - all fixes need a ticket and associated pull requests On Sep 13, 2011 7:57 AM, "Stefan van der Walt" < reply@reply.github.com> wrote:

Maybe just create issues and label them appropriately?

On Fri, Sep 9, 2011 at 1:39 AM, Riaan van den Dool reply@reply.github.com wrote:

We need a file that lists 'known issues'.

First candidate: Image data should be double, otherwise strange things might happen.

Reply to this email directly or view it on GitHub: https://github.com/nfaggian/python-register/issues/20

Reply to this email directly or view it on GitHub: https://github.com/nfaggian/python-register/issues/20#issuecomment-2075883

Reply to this email directly or view it on GitHub: https://github.com/nfaggian/python-register/issues/20#issuecomment-2076379

Reply to this email directly or view it on GitHub: https://github.com/nfaggian/python-register/issues/20#issuecomment-2078947

stefanv commented 13 years ago

On Tue, Sep 13, 2011 at 9:15 AM, Nathan Faggian reply@reply.github.com wrote:

Basically I think we should adopt the push/pull model, so each of us clone and submit a pull-request for changes.

I don't expect anything to really change - instead of making a branch on the shared repo we would just clone and issue pull requests. Ideally not pulling our own changes in, which forces us to review each others code and discuss the best approach for things.

Hope this isn't too much of a nuisance.

We use this model with scikits.image as well. It's pretty easy now that GitHub allows you to automatically merge requests.

The important thing is never to work on a feature in your master branch. The master branch should always track the main repo.

riaanvddool commented 12 years ago

Closing this as it has become a bit irrelevant.