Exception with --ssh-user/--user CLI option and click<7.0

[gchazot]

Describe the bug

# pipenv run -- pyinfra 192.168.1.1 --ssh-user root --ssh-key my_key files.put scripts/shred_disks.sh /tmp/shred_disks.sh
--> An unexpected internal exception occurred:

  File "/home/foobar/.virtualenvs/myvenv/lib/python3.9/site-packages/pyinfra_cli/main.py", line 236, in cli
    _main(*args, **kwargs)
TypeError: _main() got an unexpected keyword argument 'user'

--> The full traceback has been written to pyinfra-debug.log
--> If this is unexpected please consider submitting a bug report on GitHub, for more information run `pyinfra --support`.

To Reproduce

• Install click <= 6.7
• Install pyinfra >= 1.4
• Run the CLI with any of the --ssh-blah or corresponding --blah option

Expected behavior

No exception is raised :-D

Meta

• Include output of pyinfra --support.

  $ pipenv run pyinfra --support
  --> Support information:
  
  If you are having issues with pyinfra or wish to make feature requests, please
  check out the GitHub issues at https://github.com/Fizzadar/pyinfra/issues .
  When adding an issue, be sure to include the following:
  
  System: Linux
    Platform: Linux-5.13.0-28-generic-x86_64-with-glibc2.34
    Release: 5.13.0-28-generic
    Machine: x86_64
  pyinfra: v1.6.3
  Executable: /home/foobar/.virtualenvs/myvcenv/bin/pyinfra
  Python: 3.9.10 (CPython, GCC 11.2.0)

• How was pyinfra installed (source/pip)? Pipenv (pip), pipfile extract:

  [packages]
  click = "~=6.7"
  pyinfra = "~=1.2, !=1.14.14"

• Include pyinfra-debug.log (if one was created)

  File "/home/germain/.virtualenvs/autoprovision-mkr5ct_t/lib/python3.9/site-packages/pyinfra_cli/main.py", line 236, in cli
  _main(*args, **kwargs)
  TypeError: _main() got an unexpected keyword argument 'user'

• Consider including output with -vv and --debug. Same output as pyinfra-debug.log content

[gchazot]

I've also come down further to the bottom of this issue.It is a side effect of:

• the prefixing of the SSH options with ssh- while keeping the old option available (in this PR)
• the fixing of the selection of the long option name in Click (in this PR)

So this is a bit borderline bugfix on click side that broke backwards compatibility (and is not documented in the CHANGELOG :-1: ) but this causes a bug in pyinfra.

I think there are a couple of options to improve the situation and they're both quite simple:

1. update pyinfra install requirements to need click>=7.0.
2. make pyinfra compatible with both click situations by specifying explicitely the name of the option.

I think option 2 is the nicest as it introduces explicit naming, and avoids forcing users to upgrade both pyinfra and click

[gchazot]

PR #765 Implements the change for option 2. above