pyinfra-dev / pyinfra

pyinfra turns Python code into shell commands and runs them on your servers. Execute ad-hoc commands and write declarative operations. Target SSH servers, local machine and Docker containers. Fast and scales from one server to thousands.
https://pyinfra.com
MIT License
3.91k stars 382 forks source link

CI fails on Alpine docker - FileNotFoundError: [Errno 2] No such file or directory: 'ssh' #908

Closed melezhik closed 2 years ago

melezhik commented 2 years ago

Describe the bug

unit tests fail in Apine docker instance with an error - “ FileNotFoundError: [Errno 2] No such file or directory: 'ssh'”

In absence of ssh setup , should ssh tests be optional ?

To Reproduce

Run SparrowCI.

See error report - https://ci.sparrowhub.io/report/1507

Expected behavior

Unit tests should pass.

Meta

See details in https://ci.sparrowhub.io/report/1507

Fizzadar commented 2 years ago

This appears to be an issue because the SSH config test uses the ssh command in the proxy config, I've switched this to echo in https://github.com/Fizzadar/pyinfra/commit/e3fee1d846177eca27484ddc4b4c095051790e14.

Also worth noting I don't think counts as a bug - the CI/tests are officially supported on GitHub CI only.

melezhik commented 2 years ago

Also worth noting I don't think counts as a bug - the CI/tests are officially supported on GitHub CI only.

Sorry, I don’t get that. you just said this is a bug 😊, bugs appear in a code not in systems that reveal bugs