pyinstaller / pyinstaller-hooks-contrib

Community maintained hooks for PyInstaller.
Other
96 stars 126 forks source link

Trame suite hooks #773

Closed MattTheCuber closed 3 months ago

MattTheCuber commented 3 months ago

Which library is the hook for?

All Trame libraries. Examples:

Have you gotten the library to work with pyinstaller?

Yes, by creating a hook for each library with the line datas = collect_data_files("LIBRARY_NAME", subdir="module").

Additional context

Most (maybe all) Trame libraries have a data folder called module that needs to be collected. I was planning to create a bunch of PRs for each repo, but I thought maybe there would be a good way to get all the libraries in one-shot to future proof against new Trame libraries as they frequently come out.

MattTheCuber commented 3 months ago

I am happy to implement these hooks, please advise on how I should proceed.

MattTheCuber commented 3 months ago

Oh, I just found trame-vtk uses the folder name modules, not module :/

rokm commented 3 months ago

Do those dists install everything under one trame importable package, or under separate importable packages (e.g., trame_client, trame_components, etc.)? If the latter, you will probably need to hook each of them anyway.

MattTheCuber commented 3 months ago

They are separate importable packages

rokm commented 3 months ago

They will need separate hooks then, one per importable package. But you can put them all in one PR (separate or one commit, up to you).

MattTheCuber commented 3 months ago

Can you assign this issue to me?

rokm commented 3 months ago

Can you assign this issue to me?

Sure, if it makes any difference.