search

pyinvoke / invocations

Reusable Invoke tasks
http://invocations.readthedocs.io
BSD 2-Clause "Simplified" License
165 stars 28 forks source link

Restrict enum34 dependency to python < 3.4 #17

Closed martsa1 closed 3 years ago

martsa1 commented 4 years ago

Hi folks,

I recently migrated a python project from 3.4 to 3.6 and bumped into an issue caused by a dependency on enum34.

Having a dig around, that dependency is drawn from invocations itself, but is caused because the backport doesn't include features that the 3.6 enum stdlib does include.

Can we consider pinning the enum34 dependency to python <3.4?

jefftriplett commented 4 years ago

Related to #21 too.

utapyngo commented 3 years ago

I am not sure that this issue is resolved. The closed pull request is named "Only install enum34 on python2", and it does not seem to affect Python 3.

bitprophet commented 3 years ago

@utapyngo That PR tells packaging metadata (eg pip) to not even consider the enum34 dependency on python "< 3" - so it should cover this problem entirely. No Python 3 interpreters should install enum34 when installing the latest invocations release.

utapyngo commented 3 years ago

I see, thanks. This means that versions of Python 3 before 3.4 are not supported, right?

bitprophet commented 3 years ago

@utapyngo Correct, but those have not been supported anyways, so it's not a problem :)