search

pyinvoke / invocations

Reusable Invoke tasks
http://invocations.readthedocs.io
BSD 2-Clause "Simplified" License
165 stars 28 forks source link

Restrict Enum34 dependency to python 3.4 or less. #18

Closed martsa1 closed 3 years ago

martsa1 commented 4 years ago

Resolves #17

martsa1 commented 4 years ago

It looks like one of the tests is failing due to an error with PyYaml (I hit this at work recently as well), restricting pyyaml to version 5.2 (the last version to support 3.4) may perhaps fix?

martsa1 commented 4 years ago

Ping @bitprophet is there any chance we could land this PR in the near future? Apologies for the spam.

martsa1 commented 4 years ago

I don't think I have permission to merge this, could someone who does please do so?

bitprophet commented 3 years ago

Merged #21 instead, apologies!

utapyngo commented 3 years ago

@bitprophet is there any reason why #21 has been merged instead of this PR? The changes are not identical.

bitprophet commented 3 years ago

See https://github.com/pyinvoke/invocations/issues/17#issuecomment-768393501

martsa1 commented 3 years ago

Change makes sense, thanks. 👍