search

pyinvoke / invoke

Pythonic task management & command execution.
http://pyinvoke.org
BSD 2-Clause "Simplified" License
4.31k stars 365 forks source link

Fix: call parent `stop()` on `Local` runner #911

Closed puerkito66 closed 1 year ago

puerkito66 commented 1 year ago

This should be able to fix #910

fruch commented 1 year ago

LTGM

we've recently move to 2.0.0

and out stderr is filled with the following:

19:04:53  Traceback (most recent call last):
19:04:53    File "/usr/local/lib/python3.10/threading.py", line 1009, in _bootstrap_inner
19:04:53      self.run()
19:04:53    File "/usr/local/lib/python3.10/threading.py", line 1358, in run
19:04:53      self.function(*self.args, **self.kwargs)
19:04:53    File "/usr/local/lib/python3.10/site-packages/invoke/runners.py", line 1292, in kill
19:04:53      os.kill(pid, signal.SIGKILL)
19:04:53  ProcessLookupError: [Errno 3] No such process
bitprophet commented 1 year ago

Pushed my own commit with tests/changelog - thanks!