search

pyinvoke / invoke

Pythonic task management & command execution.
http://pyinvoke.org
BSD 2-Clause "Simplified" License
4.38k stars 367 forks source link

refactor: replace imp with importlib #919

Closed kuwv closed 1 year ago

kuwv commented 1 year ago

@bitprophet This is mostly there. Just need to sort the issues with program.

kuwv commented 1 year ago

@bitprophet looks like I got the tests working. Need to remove load_module and this should be ready to go. Can you confirm if this looks fine or not?

kuwv commented 1 year ago

@bitprophet alright importlib is passing. Ready for review!

kuwv commented 1 year ago

675

829

kuwv commented 1 year ago

I have additional changes to remove the parent path from 'load()' and retrieve it from the module. But that's something that could have been done before so...

joerg-tt commented 1 year ago

Great! Hope this gets merged soon.

kuwv commented 1 year ago

@jefftriplett could you give this a review?

kuwv commented 1 year ago

@bitprophet ping

bitprophet commented 1 year ago

I'll try to find the time to review this in depth next time I'm doing Invoke-y things. Pairs well with the typing update that is yet unreleased, I'd prob pop both out as a 'support' minor version bump when I do this. thanks! 🙏🏻

kuwv commented 1 year ago

Great to see you back.

For the release... there's one caveat, I removed decorator.py because it wasn't used but then realized it's being consumed by fabric.

bitprophet commented 1 year ago

Thrusting my head above the surface of the Paramiko swamp for a gasp of air & to actually look at this 🙏🏻 unless something drastic happens I'll try to pop out invoke 2.1 today with this plus all of your other recent work!

bitprophet commented 1 year ago

Rebased onto an unrelated fix so now github's behind the times, but this is merged and on pypi! thanks again 🙏🏻