search

pyinvoke / invoke

Pythonic task management & command execution.
http://pyinvoke.org
BSD 2-Clause "Simplified" License
4.31k stars 365 forks source link

fix: resolve config regression with new loader capability #949

Closed kuwv closed 1 year ago

kuwv commented 1 year ago

@bitprophet Seems there is an idiosyncrasy with how the new loader provides the parent path. I switched it to cwd but I'm sure there are some additional details here.

Issue is here: https://github.com/pyinvoke/invoke/issues/944

kuwv commented 1 year ago

Also resolve issue for typing within parser https://github.com/pyinvoke/invoke/issues/948.

ghost commented 1 year ago

Thanks for jumping on this, just hit it myself at work 😂 I'm not sure cwd is entirely accurate, if we want to mimic the old behavior, it needs to be "next to tasks/" (i.e. same as if it were a tasks.py). This feels/smells a lot like the previous bug related to the loader change, IIRC.

I'll have a poke shortly.

kuwv commented 1 year ago

@bitprophet I know this is completed but I didn't see the pull request. Did you fix it locally?

ghost commented 1 year ago

Yea I committed locally, I don't normally make PRs for my own work unless I require longer term input from stakeholders. See https://github.com/pyinvoke/invoke/commit/aa8b815d7a7a43c8ac814c6deb9c4555b8ac6b9e - sorry I missed closing this out!