Closed pmrv closed 4 months ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
pyiron_atomistics/sphinx/interactive.py | 3 | 5 | 60.0% | ||
pyiron_atomistics/atomistics/job/atomistic.py | 39 | 47 | 82.98% | ||
<!-- | Total: | 46 | 56 | 82.14% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
pyiron_atomistics/atomistics/job/atomistic.py | 4 | 76.94% | ||
<!-- | Total: | 4 | --> |
Totals | |
---|---|
Change from base Build 9407382474: | 0.05% |
Covered Lines: | 10677 |
Relevant Lines: | 15015 |
Fine by me as long as integration tests pass
Mh, seems this is actually broken on main, as it also pop up in #1426. I cannot actually run this test locally (hangs indefinitely), do you have an idea?
Yeah it looks like it's a Sphinx problem right? Somehow it doesn't appear in my environment...
I just checked everywhere but I just cannot reproduce the error...
Ah now I updated the conda environment and it started appearing. Now I'll look into it.
Previously we indexed into the job itself, but that also triggers a search for (possibly) compressed files and is slow. Since we only intend to look into the HDF anyway, we just do it directly now.
May fix https://github.com/pyiron/pyiron_base/issues/1347