pyiron / pyiron_atomistics

pyiron_atomistics - an integrated development environment (IDE) for atomistic simulation in computational materials science.
https://pyiron-atomistics.readthedocs.io
BSD 3-Clause "New" or "Revised" License
44 stars 15 forks source link

Update pyiron_base to 0.8.0 #1367

Closed jan-janssen closed 7 months ago

jan-janssen commented 7 months ago

Once this pull request is merged, we can move ahead with: https://github.com/pyiron/pyiron_atomistics/pull/1356 , https://github.com/pyiron/pyiron_atomistics/pull/1367 There is no direct dependence still they are all centred around the introduction of the to_dict() and from_dict() functions.

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 8444286005

Details


Totals Coverage Status
Change from base Build 8444270682: 0.0%
Covered Lines: 14201
Relevant Lines: 15228

💛 - Coveralls
pmrv commented 7 months ago

Seems tests are ok, so all good for me.

jan-janssen commented 7 months ago

Seems tests are ok, so all good for me.

Yes, the question is just if we want to release a pyiron_atomistics=0.4.18 version including https://github.com/pyiron/pyiron_atomistics/pull/1347 or if we directly move ahead to pyiron_atomistics=0.5.0 and based on the updated pyiron_base=0.8.0.

jan-janssen commented 7 months ago

Close this in favour of https://github.com/pyiron/pyiron_atomistics/pull/1370