Closed jan-janssen closed 5 months ago
Totals | |
---|---|
Change from base Build 8444270682: | 0.0% |
Covered Lines: | 14201 |
Relevant Lines: | 15228 |
Seems tests are ok, so all good for me.
Seems tests are ok, so all good for me.
Yes, the question is just if we want to release a pyiron_atomistics=0.4.18
version including https://github.com/pyiron/pyiron_atomistics/pull/1347 or if we directly move ahead to pyiron_atomistics=0.5.0
and based on the updated pyiron_base=0.8.0
.
Close this in favour of https://github.com/pyiron/pyiron_atomistics/pull/1370
Once this pull request is merged, we can move ahead with: https://github.com/pyiron/pyiron_atomistics/pull/1356 , https://github.com/pyiron/pyiron_atomistics/pull/1367 There is no direct dependence still they are all centred around the introduction of the
to_dict()
andfrom_dict()
functions.