pyiron / pyiron_atomistics

pyiron_atomistics - an integrated development environment (IDE) for atomistic simulation in computational materials science.
https://pyiron-atomistics.readthedocs.io
BSD 3-Clause "New" or "Revised" License
42 stars 15 forks source link

changed the generic cells property #1379

Closed skatnagallu closed 4 months ago

skatnagallu commented 4 months ago

Changed the cells property to repeat based on number of steps to fix issue #1378

skatnagallu commented 4 months ago

Unittest fails with AttributeError: energy_free. I am not sure why

freyso commented 4 months ago

I think this approach is suboptimal.

The relaxHist.sx output replicates the cell, so it should be parsable (and it actually seems to be parsed into "output.cell" rather than ...".cells" (with s), see sphinx/output_parsers.py lines 192-196. I'd rather rename the parsing target in the parser, because then we would be ready for future implementations of automatic cell optimization.

samwaseda commented 4 months ago

Based on @freyso's comment, I suggest to copy generic.cell, which will probably also solve the problem with CI

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 8720068328

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/init.py 1 97.92%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 8572185654: 0.01%
Covered Lines: 14275
Relevant Lines: 15315

💛 - Coveralls
skatnagallu commented 4 months ago

Shouldn't we change the key to 'cells' here ?

samwaseda commented 4 months ago

Shouldn't we change the key to 'cells' here ?

I guess we should discuss it at the pyiron meeting. For now if the tests pass we can live with what we get here.

skatnagallu commented 4 months ago

can be merged now