search

pyiron / pyiron_atomistics

pyiron_atomistics - an integrated development environment (IDE) for atomistic simulation in computational materials science.
https://pyiron-atomistics.readthedocs.io
BSD 3-Clause "New" or "Revised" License
39 stars 15 forks source link

Remove elastic tensor job #1388

Closed jan-janssen closed 3 months ago

jan-janssen commented 3 months ago

To minimise the confusion with ElasticMatrixJob the ElasticTensor job is transferred to pyiron_contrib, as discussed in https://github.com/pyiron/pyiron_atomistics/pull/1375

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 8682595803

Details

Totals Coverage Status
Change from base Build 8682567212: -0.1%
Covered Lines: 13985
Relevant Lines: 15024
💛 - Coveralls
pmrv commented 3 months ago

Would be good to use the module conversion setup as in contrib

https://github.com/pyiron/pyiron_contrib/blob/1409ce51314a32af27bdc2273b7a11fc2552d9ea/pyiron_contrib/__init__.py#L93

Users of the old elastic job should be able to use already existing maintenance functions once those module conversions are added.

jan-janssen commented 3 months ago

I opened the corresponding pull request in https://github.com/pyiron/pyiron_contrib/pull/1040