pyiron / pyiron_atomistics

pyiron_atomistics - an integrated development environment (IDE) for atomistic simulation in computational materials science.
https://pyiron-atomistics.readthedocs.io
BSD 3-Clause "New" or "Revised" License
39 stars 15 forks source link

Additional inputs to phonopy #1418

Closed raynol-dsouza closed 1 month ago

raynol-dsouza commented 2 months ago
  1. In order to calculate the projected DOS (either internally with phonopy or externally using a custom script), one needs the eigenvectors of the dynamical matrix at each (ideally irreducible) qpoint. This is by default hard-coded to be False in pyiron. I add an additional input to allow to save these eigenvectors if necessary.

  2. Phonopy has 2(?) methods for the integration over the Brillouin zone: the tetrahedron method (phonopy default, hard coded in pyiron) and the Gaussian smearing method (sigma calculated internally by phonopy). I also add an additional input to allow to change the default.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 9094382462

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/atomistics/master/phonopy.py 2 4 50.0%
<!-- Total: 2 4 50.0% -->
Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/atomistics/master/phonopy.py 1 45.5%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9047055407: 0.004%
Covered Lines: 10629
Relevant Lines: 14958

💛 - Coveralls
raynol-dsouza commented 2 months ago

@jan-janssen Thanks for the format black commit!

raynol-dsouza commented 2 months ago

@pmrv yes, you are right. But this involves executing job.phonopy.run_mesh() again, which is basically repeating what could just be done once. It is also quite memory intensive to do it on demand depending on how dense the qpoint mesh is.