pyiron / pyiron_atomistics

pyiron_atomistics - an integrated development environment (IDE) for atomistic simulation in computational materials science.
https://pyiron-atomistics.readthedocs.io
BSD 3-Clause "New" or "Revised" License
44 stars 15 forks source link

LAMMPS: Implement calculate() function #1446

Closed jan-janssen closed 4 months ago

jan-janssen commented 4 months ago

Switch the LAMMPS job to the calculate() function as it is introduced in https://github.com/pyiron/pyiron_base/pull/1477 . The pull request is expected to fail until https://github.com/pyiron/pyiron_base/pull/1477 is merged.

With these new changes it is possible to evaluate LAMMPS jobs as functions. For a classical LAMMPS job you would use:

from pyiron_atomistics import Project

pr = Project("test")
job = pr.create.job.Lammps("lmp")
job.structure = pr.create.structure.ase.bulk("Al", cubic=True)
job.run()

This still works, but in addition you can also use an external executor:

from pyiron_atomistics import Project
from concurrent.futures import ProcessPoolExecutor

pr = Project("test")
job = pr.create.job.Lammps("lmp")
job.structure = pr.create.structure.ase.bulk("Al", cubic=True)

with ProcessPoolExecutor() as exe:
    fs = exe.submit(job.get_calculate_function(), **job.calculate_kwargs)
    shell_output, output_dict, job_crashed = fs.result()

job.save_output(output_dict=output_dict, shell_output=shell_output)
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9444291497

Details


Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/lammps/potential.py 2 62.5%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 9438715818: 0.002%
Covered Lines: 10678
Relevant Lines: 15000

πŸ’› - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9471820921

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/lammps/potential.py 2 62.5%
pyiron_atomistics/dft/bader.py 4 92.73%
pyiron_atomistics/vasp/base.py 211 66.1%
<!-- Total: 217 -->
Totals Coverage Status
Change from base Build 9438715818: -0.001%
Covered Lines: 10679
Relevant Lines: 15002

πŸ’› - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9476628334

Details


Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/lammps/potential.py 2 62.5%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 9450521916: 0.002%
Covered Lines: 10679
Relevant Lines: 15002

πŸ’› - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9476697150

Details


Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/lammps/potential.py 2 62.5%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 9450521916: 0.002%
Covered Lines: 10679
Relevant Lines: 15002

πŸ’› - Coveralls
jan-janssen commented 4 months ago

This comment is no longer valid.

jan-janssen commented 4 months ago

Waiting for https://github.com/pyiron/pyiron_base/pull/1477

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9477283041

Details


Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/lammps/potential.py 2 62.5%
pyiron_atomistics/lammps/output.py 19 87.18%
pyiron_atomistics/lammps/base.py 29 80.2%
<!-- Total: 50 -->
Totals Coverage Status
Change from base Build 9477094720: 0.002%
Covered Lines: 10693
Relevant Lines: 15018

πŸ’› - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9609063823

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/lammps/output.py 4 5 80.0%
pyiron_atomistics/lammps/base.py 69 101 68.32%
<!-- Total: 73 106 68.87% -->
Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/lammps/base.py 1 79.85%
pyiron_atomistics/lammps/interactive.py 1 45.14%
pyiron_atomistics/lammps/potential.py 2 62.5%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 9608395794: -0.008%
Covered Lines: 10687
Relevant Lines: 15014

πŸ’› - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9609156113

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/lammps/output.py 4 5 80.0%
pyiron_atomistics/lammps/base.py 69 101 68.32%
<!-- Total: 73 106 68.87% -->
Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/lammps/base.py 1 79.85%
pyiron_atomistics/lammps/interactive.py 1 45.14%
pyiron_atomistics/lammps/potential.py 2 62.5%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 9608395794: -0.008%
Covered Lines: 10687
Relevant Lines: 15014

πŸ’› - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9609216747

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/lammps/output.py 4 5 80.0%
pyiron_atomistics/lammps/base.py 69 101 68.32%
<!-- Total: 73 106 68.87% -->
Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/lammps/base.py 1 79.85%
pyiron_atomistics/lammps/interactive.py 1 45.14%
pyiron_atomistics/lammps/potential.py 2 62.5%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 9608395794: -0.008%
Covered Lines: 10687
Relevant Lines: 15014

πŸ’› - Coveralls