search

pyiron / pyiron_nodes

Prototype node library for pyiron_workflows
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Enable forks here? #3

Closed ligerzero-ai closed 1 month ago

ligerzero-ai commented 3 months ago

I need to be able to fork the repo to have a clone of this available in the matdigital workflow store, as per Tilmann's request

(If we are set on this one that will be the node repository)

liamhuber commented 3 months ago

The inability to fork is (almost certainly) because this is a private repository.

I have admin rights to the repo as a member of the pyiron admin team, but interestingly under "change visibility" I nonetheless get the warning "Organization members can’t change repo visibility" and no option to take it public. Over on pyiron_workflow I played around leveraging those admin rights to add me, individually to to the administrators list, but the same roadblock persists there. I guess we need a pyiron organization owner to take the repo public.

However, I would suggest that fork permissions are not the immediate roadblock to using this repo for the matdigital store. First you probably want to write down some guidelines for what sort of repo qualifies for inclusion. As a minimum bar, I suggest requiring a provably-buildable environment and at least partial test coverage of the nodes (e.g. that the example notebooks run).

That bar gets passed by the parallel repository https://github.com/pyiron/node_library/, which I made when this repo was private even from me. That repo is ahead in integration with pyiron_workflow-0.8.0, but behind in functionality as Joerg added more stuff here since the histories of the two repos forked. If you just want a public repo to test out store interaction, feel free to use that one, but don't put it anywhere permanent and irrevocable as in the medium term you're extremely likely to want this repo instead.

In terms of getting this repo up-to-speed, verifying that the notebooks run and getting the currently-existing nodes integrated with some new tools in pyiron_workflow is on my TODO list, but it's not super high priority. I imminently need to make a poster that is likely to leverage some of Joerg's nodes, so there's a good chance I'll make partial progress. I don't currently have a plan to build a thorough set of unit tests for all the nodes, but it's not off-the-table for the Fall.