Merge main into vasp_nodes

liamhuber commented 3 months ago

The only meaningful change to the branch is that the parent python module is now pyiron_nodes instead of node_library. PyCharm seems to have intelligently re-located the two new module files even though I accepted the branch version when I got a merge conflict.

EDIT: I made the following commits modifying the actual branch content to try to get CI running

@ligerzero-ai, this is mostly just bug fixing pathing stuff, but please take a critical look at https://github.com/pyiron/pyiron_nodes/commit/c8d4a948a5b942f976b0a2d503c37943bfbb4a98 -- whatever cool thing you're doing with mock doesn't run as-is and I didn't understand it, so I just axed it 😬 Otherwise this just patches your branch to get it sync'd with main and running the CI

review-notebook-app[bot] commented 3 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

liamhuber commented 3 months ago

Path fixes were easy (and now running on my local machine), but I'm still working on

======================================================================
ERROR: test_run_job (test_vasp.TestVaspJob.test_run_job)
----------------------------------------------------------------------
TypeError: TestVaspJob.test_run_job() missing 1 required positional argument: 'mock_subprocess_run'

codacy-production[bot] commented 3 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for 6378bf253af5bdeb9950136bdc011de5374d1b8f[^1]	:white_check_mark: 3.57%

Coverage variation details

| | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (6378bf253af5bdeb9950136bdc011de5374d1b8f) | Report Missing | Report Missing | Report Missing | | | Head commit (133cdea7559a961f02652af2ec68a655acdc885e) | 1401 | 129 | 9.21% | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `

Diff coverage details

| | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#45) | 56 | 2 | **3.57%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more} [^1]: Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

liamhuber commented 3 months ago

Super! I'll merge this and then review your PR tomorrow 👍

pyiron / pyiron_nodes