search

pyiron / pyiron_ontology

Combining pyiron and owlready2 for ontologically guided workflow design
BSD 3-Clause "New" or "Revised" License
4 stars 0 forks source link

Test atomistics #22

Closed liamhuber closed 1 year ago

liamhuber commented 1 year ago

The coverage is terrible because the atomistics onto never gets spun up outside the notebooks. This should fix that, and add something in the tests so that at least this onto can instantiate fine. Deeper tests I'll leave to the notebooks workflow.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

github-actions[bot] commented 1 year ago

Binder :point_left: Launch a binder notebook on branch _pyiron/pyiron_ontology/testatomistics

codacy-production[bot] commented 1 year ago

Coverage summary from Codacy

Merging #22 (92446d6a79e036edc22870b9b00951fddd4d0be9) into main (4f26dea5c3514f007f96dc30eaf30fc6738fc937) - See PR on Codacy

Coverage variation Diff coverage
Report missing for 4f26dea5c3514f007f96dc30eaf30fc6738fc937[^1] ∅
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (4f26dea5c3514f007f96dc30eaf30fc6738fc937) | Report Missing | Report Missing | Report Missing | | | Head commit (92446d6a79e036edc22870b9b00951fddd4d0be9) | 457 | 399 | 87.31% | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#22) | 0 | 0 | **∅ (not applicable)** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

[^1]: Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.