pyiron / pyiron_ontology

Combining pyiron and owlready2 for ontologically guided workflow design
BSD 3-Clause "New" or "Revised" License
4 stars 0 forks source link

Update pyiron_atomistics optional dependency #44

Closed liamhuber closed 10 months ago

liamhuber commented 10 months ago

And get it as an extras require in setup.py so dependabot sees it

github-actions[bot] commented 10 months ago

Binder :point_left: Launch a binder notebook on branch _pyiron/pyiron_ontology/update_atomistics_optionaldep

liamhuber commented 10 months ago
from maggma.utils import get_flat_models_from_model
    ImportError: cannot import name 'get_flat_models_from_model' from 'maggma.utils' (/usr/share/miniconda3/envs/my-env/lib/python3.11/site-packages/maggma/utils.py)

Because mpi-api is 0.37.2, not 0.39.5, because pyiron_atomistics allows a lower bound of 0.37.0. I've actually run into exactly this before, I just forgot that conda is allowing that broken lower bound.

codacy-production[bot] commented 10 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.00% (target: -1.00%) :white_check_mark:
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (5eb4759353e28caacf945dad38697957e32e489b) | 459 | 418 | 91.07% | | | Head commit (7a7d06d05b0249d9a9d876acc8be5a5be7a4884a) | 459 (+0) | 418 (+0) | 91.07% (**+0.00%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#44) | 0 | 0 | **∅ (not applicable)** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation