Closed liamhuber closed 10 months ago
Coverage variation | Diff coverage |
---|---|
:white_check_mark: +0.03% (target: -1.00%) | :white_check_mark: 100.00% |
You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation
Actually I don't really get the intention of this PR. I think by default people should delete the file from FileObject
and not from the directory (except when all files should be erased)
Wouldn't that involve importing FoleObject
and creating N of these based on the strings used in this shortcut and the DirectoryObject
? This isn't horrid, I just wanted something even shorter. You can see the use in Node.__post__
over in the storage PR
Totals | |
---|---|
Change from base Build 7534135240: | 0.02% |
Covered Lines: | 4676 |
Relevant Lines: | 5179 |
@samwaseda if, on reflection, you think this is useful, feel free to merge it. However, I came around to your perspective that importing and instantiating a FileObject
is also perfectly acceptable, and in my case (since I have only the one file I care about and already import DirectoryObject
) not particularly more work. I've dropped it from the history of #160 and don't depend on it.
So if you still dislike it, just close the PR; I still don't hate it, but am quite indifferent now.
Still not really sure about this one, but I also don't feel strongly against it, so I merged it :D
Introduces the following convenience method to
DirectoryObject
: