pyiron / pyiron_workflow

Graph-and-node based workflows
BSD 3-Clause "New" or "Revised" License
12 stars 1 forks source link

Storage (& DB & information management...): git-copy `tinybase` here #161

Closed liamhuber closed 9 months ago

liamhuber commented 10 months ago

Per the discussion with me, @pmrv, @JNmpi this morning, let's "git-copy" tinybase out of pyiron_contrib and include it (just the whole thing for now) as a sub-module here, i.e. pyiron_contrib.tinybase::tinydata --> pyiron_workflow.tinybase.

This way it can be leveraged without the heavy import cost of contrib.

niklassiemer commented 10 months ago

Fine with me, another solution could be to not import any submodules of contrib by default, i.e. only import stuff from contrib if it really wanted by an explicit call (of course this only reduces the import time, not the number of possible dependencies)

liamhuber commented 9 months ago

Both pyiron_base and, critically, pyiron_contrib now import much faster, so this is no longer so critical. Additionally, the tentative plan is to break tinybase.storage off into its own thing independent of the workflows, so I will close this as a todon't