pyiron / pyiron_workflow

Graph-and-node based workflows
BSD 3-Clause "New" or "Revised" License
12 stars 1 forks source link

Make DirectoryObject recognize various init variables #216

Closed samwaseda closed 9 months ago

samwaseda commented 9 months ago

I think it's straightforward enough, but this PR is to make DirectoryObject recognise str, Path and DirectoryObject for the directory instantiation.

I guess this is the first one to be merged. Sorry for going back and forth all the time!

github-actions[bot] commented 9 months ago

Binder :point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/file_directory_of_directoryobject

codacy-production[bot] commented 9 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.03% (target: -1.00%) :white_check_mark: 100.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (7fcae5f00f9873a1f5e35301c4aedb8ab5e1aaf5) | 3065 | 2659 | 86.75% | | | Head commit (6c1c6f0cfcf77f3e1de7b752d0ab6e14da7425e8) | 3071 (+6) | 2665 (+6) | 86.78% (**+0.03%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#216) | 8 | 8 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 7970400900

Details


Files with Coverage Reduction New Missed Lines %
snippets/files.py 4 93.59%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 7939797536: 0.02%
Covered Lines: 5705
Relevant Lines: 6255

💛 - Coveralls
samwaseda commented 9 months ago

@liamhuber I made this project to make a better overview. Hopefully it helps a bit.

samwaseda commented 9 months ago

Since the distinction won't be needed if DirectoryObject is derived from Path, I close this PR.