pyiron / pyiron_workflow

Graph-and-node based workflows
BSD 3-Clause "New" or "Revised" License
12 stars 1 forks source link

pyiron_base's wrapper doesn't use storage #220

Closed liamhuber closed 9 months ago

liamhuber commented 9 months ago

It serializes the entire node to bytestream directly, so we should be able to run this job type on all supported python versions not just 3.11+.

github-actions[bot] commented 9 months ago

Binder :point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/wrapper_doesnt_needstorage

codacy-production[bot] commented 9 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.02% (target: -1.00%) :white_check_mark: 100.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (2da58062d401c8251fdfcdb7852aac2578f034fc) | 3065 | 2659 | 86.75% | | | Head commit (cbe31dc894251cce1c91c9aef80d28f745662618) | 3063 (-2) | 2658 (-1) | 86.78% (**+0.02%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#220) | 1 | 1 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 7977940738

Details


Files with Coverage Reduction New Missed Lines %
job.py 4 94.59%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 7977911098: 0.07%
Covered Lines: 5691
Relevant Lines: 6236

💛 - Coveralls
liamhuber commented 9 months ago
OutputSignals ['ran'] (key node__index_0): DataContainer doesn't support saving elements of type "<class 'pyiron_workflow.workflow.Workflow'>" to HDF!

My guess is that under the hood we need h5io's __getstate__ for this to be working, so we're still restricted to >=3.11. IMO it's not worth digging deeper at this instant.