pyiron / pyiron_workflow

Graph-and-node based workflows
BSD 3-Clause "New" or "Revised" License
12 stars 1 forks source link

[breaking] Replace the wrapper job with a more robust job subclass #222

Closed liamhuber closed 9 months ago

liamhuber commented 9 months ago

Still, this leans directly on the storage provided by pyiron_base.jobs.flex.PythonFunctionContainerJob

Breaking: removes the create_job_with_python_wrapper interface from pyiron_workflow.job.

github-actions[bot] commented 9 months ago

Binder :point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/node_outputjob

codacy-production[bot] commented 9 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: -0.05% (target: -1.00%) :white_check_mark: 83.78%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (a6efda74dc48566df76b406c4d51761afab9c439) | 3065 | 2659 | 86.75% | | | Head commit (8a84f6050d5ce3852114a420e0af7f7f809a2f3b) | 3090 (+25) | 2679 (+20) | 86.70% (**-0.05%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#222) | 37 | 31 | **83.78%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 7979306570

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_workflow/job.py 30 32 93.75%
<!-- Total: 33 35 94.29% -->
Files with Coverage Reduction New Missed Lines %
job.py 9 89.9%
channels.py 11 94.39%
<!-- Total: 20 -->
Totals Coverage Status
Change from base Build 7978218853: 0.2%
Covered Lines: 5733
Relevant Lines: 6276

💛 - Coveralls