[patch] NodeJobOutput: Overload the save function to not change the job name

[jan-janssen]

@srmnitc This should solve the issue with the cryptic job names to be more consistent with pyiron_base.

[github-actions[bot]]

:point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/nodeoutputjobsave

[codacy-production[bot]]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
:white_check_mark: -0.02% (target: -1.00%)	:white_check_mark: 100.00%

Coverage variation details

| | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (6b60eb39a06aeb1515cd10c8494824cfedade572) | 3113 | 2701 | 86.77% | | | Head commit (ac1f72e28cfed842d3c79732f21507189107dee9) | 3115 (+2) | 2702 (+1) | 86.74% (**-0.02%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `

Diff coverage details

| | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#225) | 3 | 3 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

_{You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation}

[coveralls]

Pull Request Test Coverage Report for Build 8024667520

Details

• 0 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
• 6 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.03%) to 91.402%

---

Files with Coverage Reduction	New Missed Lines	%
pyiron_workflow/snippets/dotdict.py	1	82.35%
snippets/dotdict.py	1	82.35%
job.py	4	90.38%
<!--	Total:	6		-->

Totals
Change from base Build 8008311321:	-0.03%
Covered Lines:	5783
Relevant Lines:	6327

---

💛 - Coveralls

[jan-janssen]

The updated notebook is available in https://gitlab.mpcdf.mpg.de/janj/dpg_tutorial_2024/-/blob/main/workflows/stress_strain.ipynb - here the job names are no longer cryptic but rather the job names are the ones given in the pr.create.job.NodeJob() function call.

[liamhuber]

Sorry for the noise, I'm just trying to get the request for changes removed but also have the review status as "Comment"

I give up.

[liamhuber]

Per the meeting discussion we'll merge this now so we can get the functionality without any updates to base. I'll draft a reverting PR so we can proceed with the #227 solution once base is moving.