Closed liamhuber closed 3 months ago
Coverage variation | Diff coverage |
---|---|
:white_check_mark: +0.00% (target: -1.00%) | :white_check_mark: 100.00% |
You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
job.py | 9 | 90.29% | ||
<!-- | Total: | 9 | --> |
Totals | |
---|---|
Change from base Build 8008311321: | 0.003% |
Covered Lines: | 5783 |
Relevant Lines: | 6325 |
This won't be necessary, the next version of base will jump straight to pyrion_base 1358, so we'll get the desired renaming behaviour by default and never need to exploit the mangling flag
This depends on
pyiron_base
1356, and turns off the automatic name mangling forNodeJob
. There is certainly not a large corpus of workflow jobs depending on the old naming scheme, so this can be a patch.@jan-janssen @srmnitc, I don't know what the timetable is for the DPG or whether base releases can get made sufficiently quickly to utilize this, but it is far and away preferable to #225, which is wrongly patching a problem in
_base
but only inside_workflow
.