pyiron / pyiron_workflow

Graph-and-node based workflows
BSD 3-Clause "New" or "Revised" License
10 stars 1 forks source link

[patch] Exploit the mangling flag #226

Closed liamhuber closed 3 months ago

liamhuber commented 4 months ago

This depends on pyiron_base 1356, and turns off the automatic name mangling for NodeJob. There is certainly not a large corpus of workflow jobs depending on the old naming scheme, so this can be a patch.

@jan-janssen @srmnitc, I don't know what the timetable is for the DPG or whether base releases can get made sufficiently quickly to utilize this, but it is far and away preferable to #225, which is wrongly patching a problem in _base but only inside _workflow.

github-actions[bot] commented 4 months ago

Binder :point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/exploit_mangleflag

codacy-production[bot] commented 4 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.00% (target: -1.00%) :white_check_mark: 100.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (6b60eb39a06aeb1515cd10c8494824cfedade572) | 3113 | 2701 | 86.77% | | | Head commit (b304c697774306185e1ef636c4c1b59cd3578e1a) | 3114 (+1) | 2702 (+1) | 86.77% (**+0.00%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#226) | 1 | 1 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 8024520890

Details


Files with Coverage Reduction New Missed Lines %
job.py 9 90.29%
<!-- Total: 9 -->
Totals Coverage Status
Change from base Build 8008311321: 0.003%
Covered Lines: 5783
Relevant Lines: 6325

💛 - Coveralls
liamhuber commented 3 months ago

This won't be necessary, the next version of base will jump straight to pyrion_base 1358, so we'll get the desired renaming behaviour by default and never need to exploit the mangling flag